pgsql: Preserve index data in pg_statistic across REINDEX CONCURRENTLY - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Preserve index data in pg_statistic across REINDEX CONCURRENTLY
Date
Msg-id E1kZCQr-000059-6C@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Preserve index data in pg_statistic across REINDEX CONCURRENTLY

Statistics associated to an index got lost after running REINDEX
CONCURRENTLY, while the non-concurrent case preserves these correctly.
The concurrent and non-concurrent operations need to be consistent for
the end-user, and missing statistics would force to wait for a new
analyze to happen, which could take some time depending on the activity
of the existing autovacuum workers.  This issue is fixed by copying any
existing entries in pg_statistic associated to the old index to the new
one.  Note that this copy is already done with the data of the index in
the stats collector.

Reported-by: Fabrízio de Royes Mello
Author: Michael Paquier, Fabrízio de Royes Mello
Reviewed-by: Justin Pryzby
Discussion: https://postgr.es/m/CAFcNs+qpFPmiHd1oTXvcPdvAHicJDA9qBUSujgAhUMJyUMb+SA@mail.gmail.com
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/41a033b5054e047cc67a92e17fbbe4accb658b3b

Modified Files
--------------
src/backend/catalog/heap.c                 | 41 ++++++++++++++++++++++++++++++
src/backend/catalog/index.c                |  3 +++
src/include/catalog/heap.h                 |  1 +
src/test/regress/expected/create_index.out | 22 ++++++++++++++++
src/test/regress/sql/create_index.sql      | 12 +++++++++
5 files changed, 79 insertions(+)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add error code for encryption failure in pgcrypto
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid null pointer dereference if error result lacks SQLSTATE.