pgsql: Add CheckBuffer() to check on-disk pages without shared buffer l - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Add CheckBuffer() to check on-disk pages without shared buffer l
Date
Msg-id E1kXb3f-0005vm-Tb@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add CheckBuffer() to check on-disk pages without shared buffer loading

CheckBuffer() is designed to be a concurrent-safe function able to run
sanity checks on a relation page without loading it into the shared
buffers.  The operation is done using a lock on the partition involved
in the shared buffer mapping hashtable and an I/O lock for the buffer
itself, preventing the risk of false positives due to any concurrent
activity.

The primary use of this function is the detection of on-disk corruptions
for relation pages.  If a page is found in shared buffers, the on-disk
page is checked if not dirty (a follow-up checkpoint would flush a valid
version of the page if dirty anyway), as it could be possible that a
page was present for a long time in shared buffers with its on-disk
version corrupted.  Such a scenario could lead to a corrupted cluster if
a host is plugged off for example.  If the page is not found in shared
buffers, its on-disk state is checked.  PageIsVerifiedExtended() is used
to apply the same sanity checks as when a page gets loaded into shared
buffers.

This function will be used by an upcoming patch able to check the state
of on-disk relation pages using a SQL function.

Author: Julien Rouhaud, Michael Paquier
Reviewed-by:  Masahiko Sawada
Discussion: https://postgr.es/m/CAOBaU_aVvMjQn=ge5qPiJOPMmOj5=ii3st5Q0Y+WuLML5sR17w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c780a7a90a8e7b074405ea2007e34f94e227e695

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 92 +++++++++++++++++++++++++++++++++++++
src/include/storage/bufmgr.h        |  3 ++
2 files changed, 95 insertions(+)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Minor improvements in description of spilled counters in pg_stat
Next
From: Michael Paquier
Date:
Subject: pgsql: Add pg_relation_check_pages() to check on-disk pages of a relati