pgsql: Fix issue with --enable-coverage and the new unicode {de,re}comp - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix issue with --enable-coverage and the new unicode {de,re}comp
Date
Msg-id E1kWC14-0006jB-M7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix issue with --enable-coverage and the new unicode {de,re}composition code

genhtml has been generating the following warning with this new code:
WARNING: function data mismatch at /path/src/common/unicode_norm.c:102

HTML coverage reports care about the uniqueness of functions defined in
source files, ignoring any assumptions around CFLAGS.  783f0cc
introduced a duplicated definition of get_code_entry(), leading to a
warning and potentially some incorrect data generated in the reports.
This refactors the code so as the code has only one function
declaration, fixing the warning.

Oversight in 783f0cc.

Reported-by: Tom Lane
Author: Michael Paquier
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/207789.1603469272@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2771fcee18be0b86d2e008add20f73d175e06e90

Modified Files
--------------
src/common/unicode_norm.c | 38 +++++++++++++++++---------------------
1 file changed, 17 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add tab completion for ALTER TABLE .. FORCE ROW LEVEL SECURITY i
Next
From: Tom Lane
Date:
Subject: pgsql: Fix ancient bug in ecpg's pthread_once() emulation for Windows.