pgsql: Remove the option to build thread_test.c outside configure. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove the option to build thread_test.c outside configure.
Date
Msg-id E1kVGfl-0002DQ-Fz@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove the option to build thread_test.c outside configure.

Theoretically one could go into src/test/thread and build/run this
program there.  In practice, that hasn't worked since 96bf88d52,
and probably much longer on some platforms (likely including just
the sort of hoary leftovers where this test might be of interest).
While it wouldn't be too hard to repair the breakage, the fact that
nobody has noticed for two years shows that there is zero usefulness
in maintaining this build pathway.  Let's get rid of it and decree
that thread_test.c is *only* meant to be built/used in configure.

Given that decision, it makes sense to put thread_test.c under config/
and get rid of src/test/thread altogether, so that's what I did.

In passing, update src/test/README, which had been ignored by some
not-so-recent additions of subdirectories.

Discussion: https://postgr.es/m/227659.1603041612@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8a2121185b26d7eb439860c7a96a08c0aa3c8508

Modified Files
--------------
{src/test/thread => config}/thread_test.c | 30 +++--------------
configure                                 | 11 +++----
configure.ac                              | 10 +++---
src/Makefile                              |  2 --
src/port/thread.c                         |  3 --
src/test/Makefile                         |  2 +-
src/test/README                           | 11 ++++---
src/test/thread/.gitignore                |  1 -
src/test/thread/Makefile                  | 24 --------------
src/test/thread/README                    | 54 -------------------------------
10 files changed, 20 insertions(+), 128 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Remove obsolete ifdefs
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Use fast checkpoint in PostgresNode::backup()