pgsql: Fix ALTER TABLE .. ENABLE/DISABLE TRIGGER recursion - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix ALTER TABLE .. ENABLE/DISABLE TRIGGER recursion
Date
Msg-id E1kV02o-0004Q7-Nt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix ALTER TABLE .. ENABLE/DISABLE TRIGGER recursion

More precisely, correctly handle the ONLY flag indicating not to
recurse.  This was implemented in 86f575948c77 by recursing in
trigger.c, but that's the wrong place; use ATSimpleRecursion instead,
which behaves properly.  However, because legacy inheritance has never
recursed in that situation, make sure to do that only for new-style
partitioning.

I noticed this problem while testing a fix for another bug in the
vicinity.

This has been wrong all along, so backpatch to 11.

Discussion: https://postgr.es/m/20201016235925.GA29829@alvherre.pgsql

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a795f6782fa8b466ee47bd6d3ff8e9075237d566

Modified Files
--------------
src/backend/commands/tablecmds.c       |  2 ++
src/backend/commands/trigger.c         | 21 -------------
src/test/regress/expected/triggers.out | 56 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/triggers.sql      | 35 +++++++++++++++++++++
4 files changed, 93 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Avoid invalid alloc size error in shm_mq
Next
From: Michael Paquier
Date:
Subject: pgsql: Review format of code generated by PerfectHash.pm