pgsql: Add missing error check in pgcrypto/crypt-md5.c. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add missing error check in pgcrypto/crypt-md5.c.
Date
Msg-id E1kTS9O-0002NW-QQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add missing error check in pgcrypto/crypt-md5.c.

In theory, the second px_find_digest call in px_crypt_md5 could fail
even though the first one succeeded, since resource allocation is
required.  Don't skip testing for a failure.  (If one did happen,
the likely result would be a crash rather than clean recovery from
an OOM failure.)

The code's been like this all along, so back-patch to all supported
branches.

Daniel Gustafsson

Discussion: https://postgr.es/m/AA8D6FE9-4AB2-41B4-98CB-AE64BA668C03@yesql.se

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1eb2d7e3ea8ef683d29b4f0a81b6f21662edd1e7

Modified Files
--------------
contrib/pgcrypto/crypt-md5.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: tweak column widths in synchronous-commit-matrix table.
Next
From: Tom Lane
Date:
Subject: pgsql: Update time zone data files to tzdata release 2020c.