pgsql: Remove logging.c from the shared library of src/common/ - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Remove logging.c from the shared library of src/common/
Date
Msg-id E1kNnYN-0007Lt-6V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove logging.c from the shared library of src/common/

As fe0a1dc has proved, it is not a good concept to add to libpq
dependencies that would enforce the error output to a central logging
facility because it breaks the promise of reporting the error back to
an application in a consistent way, with the application to potentially
exit() suddenly if using pieces from for example jsonapi.c.  prairiedog
has allowed to report an actual design problem with fe0a1dc, but it will
not be around forever, so removing logging.c from libpgcommon_shlib is a
simple and much better long-term way to prevent any attempt to load the
central logging in libraries with general purposes.

Author: Michael Paquier
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/20200928073330.GC2316@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6b1c5cacec5e8305a3880b441526c47bd47c64cd

Modified Files
--------------
src/common/Makefile | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix and test snapshot behavior on standby.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Set right-links during sorted GiST index build.