pgsql: Fix memory leak in plpgsql's CALL processing. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix memory leak in plpgsql's CALL processing.
Date
Msg-id E1kNHOx-0003xn-UM@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix memory leak in plpgsql's CALL processing.

When executing a CALL or DO in a non-atomic context (i.e., not inside
a function or query), plpgsql creates a new plan each time through,
as a rather hacky solution to some resource management issues.  But
it failed to free this plan until exit of the current procedure or DO
block, resulting in serious memory bloat in procedures that called
other procedures many times.  Fix by remembering to free the plan,
and by being more honest about restoring the previous state (otherwise,
recursive procedure calls have a problem).

There was also a smaller leak associated with recalculation of the
"target" list of output variables.  Fix that by using the statement-
lifespan context to hold non-permanent values.

Back-patch to v11 where procedures were introduced.

Pavel Stehule and Tom Lane

Discussion: https://postgr.es/m/CAFj8pRDiiU1dqym+_P4_GuTWm76knJu7z9opWayBJTC0nQGUUA@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c1e044bb30f26edf54b7d5f668d18b69a0bb3ea6

Modified Files
--------------
src/pl/plpgsql/src/pl_exec.c | 91 ++++++++++++++++++++++++++++++++++----------
1 file changed, 70 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Support for ISO 8601 in the jsonpath .datetime() method
Next
From: Tom Lane
Date:
Subject: pgsql: Fix make_timestamp[tz] to accept negative years as meaning BC.