pgsql: Change LogicalTapeSetBlocks() to use nBlocksWritten. - Mailing list pgsql-committers

From Jeff Davis
Subject pgsql: Change LogicalTapeSetBlocks() to use nBlocksWritten.
Date
Msg-id E1kIPLQ-0001Ne-K2@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Change LogicalTapeSetBlocks() to use nBlocksWritten.

Previously, it was based on nBlocksAllocated to account for tapes with
open write buffers that may not have made it to the BufFile yet.

That was unnecessary, because callers do not need to get the number of
blocks while a tape has an open write buffer; and it also conflicted
with the preallocation logic added for HashAgg.

Reviewed-by: Peter Geoghegan
Discussion: https://postgr.es/m/ce5af05900fdbd0e9185747825a7423c48501964.camel@j-davis.com
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c8aeaf3ab31edeedf1791e37c74bcedf61a916ed

Modified Files
--------------
src/backend/executor/nodeAgg.c   |  2 +-
src/backend/utils/sort/logtape.c | 12 +++++++++++-
2 files changed, 12 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: HashAgg: release write buffers sooner by rewinding tape.
Next
From: Jeff Davis
Date:
Subject: pgsql: Change LogicalTapeSetBlocks() to use nBlocksWritten.