pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli - Mailing list pgadmin-hackers

From Akshay Joshi
Subject pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli
Date
Msg-id E1k8Jsu-0000at-1r@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Fixed code smell 'String literals should not be duplicated'.

Create a constant.py file which contains the common Constants.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc5a7ea334cd862ee54e4bc2f35026f40ea991d5
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>

Modified Files
--------------
web/pgadmin/browser/__init__.py                    | 109 ++++++++++-----------
web/pgadmin/browser/collection.py                  |  13 +--
.../browser/register_browser_preferences.py        |  43 ++++----
web/pgadmin/browser/server_groups/__init__.py      |  28 +++---
.../browser/server_groups/servers/__init__.py      |  24 ++---
.../server_groups/servers/databases/__init__.py    |  11 ++-
.../servers/databases/event_triggers/__init__.py   |   9 +-
.../foreign_servers/__init__.py                    |  13 +--
.../foreign_servers/user_mappings/__init__.py      |  13 +--
web/pgadmin/browser/utils.py                       |   7 ++
web/pgadmin/utils/constants.py                     |  15 +++
11 files changed, 148 insertions(+), 137 deletions(-)


pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes