pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
Date
Msg-id E1k6zqp-0008VG-0F@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent concurrent SimpleLruTruncate() for any given SLRU.

The SimpleLruTruncate() header comment states the new coding rule.  To
achieve this, add locktype "frozenid" and two LWLocks.  This closes a
rare opportunity for data loss, which manifested as "apparent
wraparound" or "could not access status of transaction" errors.  Data
loss is more likely in pg_multixact, due to released branches' thin
margin between multiStopLimit and multiWrapLimit.  If a user's physical
replication primary logged ":  apparent wraparound" messages, the user
should rebuild standbys of that primary regardless of symptoms.  At less
risk is a cluster having emitted "not accepting commands" errors or
"must be vacuumed" warnings at some point.  One can test a cluster for
this data loss by running VACUUM FREEZE in every database.  Back-patch
to 9.5 (all supported versions).

Discussion: https://postgr.es/m/20190218073103.GA1434723@rfd.leadboat.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ae01df6f6ef590fd73299050c7112f69c03f3de

Modified Files
--------------
doc/src/sgml/catalogs.sgml               |  4 +++-
doc/src/sgml/monitoring.sgml             | 20 +++++++++++++++--
src/backend/access/transam/slru.c        |  8 +++++++
src/backend/access/transam/subtrans.c    |  4 ++--
src/backend/commands/async.c             | 37 +++++++++++++++++++++++---------
src/backend/commands/vacuum.c            | 13 +++++++++++
src/backend/storage/lmgr/lmgr.c          | 20 +++++++++++++++++
src/backend/storage/lmgr/lwlocknames.txt |  2 ++
src/backend/utils/adt/lockfuncs.c        | 12 +++++++++++
src/include/storage/lmgr.h               |  3 +++
src/include/storage/lock.h               | 10 +++++++++
11 files changed, 118 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: various improvements for pg_basebackup reference page.