pgsql: snapshot scalability: Don't compute global horizons while buildi - Mailing list pgsql-committers

snapshot scalability: Don't compute global horizons while building snapshots.

To make GetSnapshotData() more scalable, it cannot not look at at each proc's
xmin: While snapshot contents do not need to change whenever a read-only
transaction commits or a snapshot is released, a proc's xmin is modified in
those cases. The frequency of xmin modifications leads to, particularly on
higher core count systems, many cache misses inside GetSnapshotData(), despite
the data underlying a snapshot not changing. That is the most
significant source of GetSnapshotData() scaling poorly on larger systems.

Without accessing xmins, GetSnapshotData() cannot calculate accurate horizons /
thresholds as it has so far. But we don't really have to: The horizons don't
actually change that much between GetSnapshotData() calls. Nor are the horizons
actually used every time a snapshot is built.

The trick this commit introduces is to delay computation of accurate horizons
until there use and using horizon boundaries to determine whether accurate
horizons need to be computed.

The use of RecentGlobal[Data]Xmin to decide whether a row version could be
removed has been replaces with new GlobalVisTest* functions.  These use two
thresholds to determine whether a row can be pruned:
1) definitely_needed, indicating that rows deleted by XIDs >= definitely_needed
   are definitely still visible.
2) maybe_needed, indicating that rows deleted by XIDs < maybe_needed can
   definitely be removed
GetSnapshotData() updates definitely_needed to be the xmin of the computed
snapshot.

When testing whether a row can be removed (with GlobalVisTestIsRemovableXid())
and the tested XID falls in between the two (i.e. XID >= maybe_needed && XID <
definitely_needed) the boundaries can be recomputed to be more accurate. As it
is not cheap to compute accurate boundaries, we limit the number of times that
happens in short succession.  As the boundaries used by
GlobalVisTestIsRemovableXid() are never reset (with maybe_needed updated by
GetSnapshotData()), it is likely that further test can benefit from an earlier
computation of accurate horizons.

To avoid regressing performance when old_snapshot_threshold is set (as that
requires an accurate horizon to be computed), heap_page_prune_opt() doesn't
unconditionally call TransactionIdLimitedForOldSnapshots() anymore. Both the
computation of the limited horizon, and the triggering of errors (with
SetOldSnapshotThresholdTimestamp()) is now only done when necessary to remove
tuples.

This commit just removes the accesses to PGXACT->xmin from
GetSnapshotData(), but other members of PGXACT residing in the same
cache line are accessed. Therefore this in itself does not result in a
significant improvement. Subsequent commits will take advantage of the
fact that GetSnapshotData() now does not need to access xmins anymore.

Note: This contains a workaround in heap_page_prune_opt() to keep the
snapshot_too_old tests working. While that workaround is ugly, the tests
currently are not meaningful, and it seems best to address them separately.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/20200301083601.ews6hz5dduc3w2se@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dc7420c2c9274a283779ec19718d2d16323640c0

Modified Files
--------------
contrib/amcheck/verify_nbtree.c             |   8 +-
contrib/pg_visibility/pg_visibility.c       |  18 +-
contrib/pgstattuple/pgstatapprox.c          |   2 +-
src/backend/access/gin/ginvacuum.c          |  26 +
src/backend/access/gist/gistutil.c          |   8 +-
src/backend/access/gist/gistxlog.c          |  10 +-
src/backend/access/heap/heapam.c            |  15 +-
src/backend/access/heap/heapam_handler.c    |  24 +-
src/backend/access/heap/heapam_visibility.c |  99 ++-
src/backend/access/heap/pruneheap.c         | 205 +++++--
src/backend/access/heap/vacuumlazy.c        |  24 +-
src/backend/access/index/indexam.c          |   3 +-
src/backend/access/nbtree/README            |  10 +-
src/backend/access/nbtree/nbtpage.c         |   4 +-
src/backend/access/nbtree/nbtree.c          |  28 +-
src/backend/access/nbtree/nbtxlog.c         |  10 +-
src/backend/access/spgist/spgvacuum.c       |   6 +-
src/backend/access/transam/README           |  82 +--
src/backend/access/transam/xlog.c           |   4 +-
src/backend/commands/analyze.c              |   2 +-
src/backend/commands/vacuum.c               |  41 +-
src/backend/postmaster/autovacuum.c         |   4 +
src/backend/replication/logical/launcher.c  |   4 +
src/backend/replication/walreceiver.c       |  17 +-
src/backend/replication/walsender.c         |  15 +-
src/backend/storage/ipc/procarray.c         | 901 +++++++++++++++++++++++-----
src/backend/utils/adt/selfuncs.c            |  20 +-
src/backend/utils/init/postinit.c           |   4 +
src/backend/utils/time/snapmgr.c            | 250 ++++----
src/include/access/ginblock.h               |   4 +-
src/include/access/heapam.h                 |  10 +-
src/include/access/transam.h                |  79 ++-
src/include/storage/bufpage.h               |   6 -
src/include/storage/proc.h                  |   8 -
src/include/storage/procarray.h             |  32 +-
src/include/utils/snapmgr.h                 |  37 +-
src/include/utils/snapshot.h                |   6 +
src/tools/pgindent/typedefs.list            |   2 +
38 files changed, 1462 insertions(+), 566 deletions(-)