pgsql: Backpatch tuplesort.c assertion. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Backpatch tuplesort.c assertion.
Date
Msg-id E1k0v4a-0006P2-64@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Backpatch tuplesort.c assertion.

Backpatch an assertion (that was originally added to Postgres 12 by
commit dd299df8189) that seems broadly useful.  The assertion can detect
violations of the HOT invariant (i.e. no two index tuples can point to
the same heap TID) when CREATE INDEX somehow incorrectly allows that to
take place.

For example, a IndexBuildHeapScan/heapam_index_build_range_scan bug
might result in two tuples that both point to the same heap TID.  If
these two tuples also happen to be duplicates, the assertion will fail.

Discussion: https://postgr.es/m/CAH2-WzmBxu4o=pMsniur+bwHqCGCmV_AOLkuK6BuU7ngA6evqw@mail.gmail.com
Backpatch: 9.5-11 only

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/87eb25535d0db49fec9b3ddb2f1c4dfd97c8805e

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 6 ++++++
1 file changed, 6 insertions(+)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Add hash_mem_multiplier GUC.
Next
From: Thomas Munro
Date:
Subject: pgsql: Use a long lived WaitEventSet for WaitLatch().