pgsql: Revert "Track statistics for spilling of changes from ReorderBuf - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Revert "Track statistics for spilling of changes from ReorderBuf
Date
Msg-id E1jupCK-0002os-30@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Track statistics for spilling of changes from ReorderBuffer".

The stats with this commit was available only for WALSenders, however,
users might want to see for backends doing logical decoding via SQL API.
Then, users might want to reset and access these stats across server
restart which was not possible with the current patch.

List of commits reverted:

caa3c4242c   Don't call elog() while holding spinlock.
e641b2a995   Doc: Update the documentation for spilled transaction
statistics.
5883f5fe27   Fix unportable printf format introduced in commit 9290ad198.
9290ad198b   Track statistics for spilling of changes from ReorderBuffer.

Additionaly, remove the release notes entry for this feature.

Backpatch-through: 13, where it was introduced
Discussion: https://postgr.es/m/CA+fd4k5_pPAYRTDrO2PbtTOe0eHQpBvuqmCr8ic39uTNmR49Eg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d973747281caece520236e93d255c654cc613ec9

Modified Files
--------------
doc/src/sgml/monitoring.sgml                    | 38 ----------------------
src/backend/catalog/system_views.sql            |  5 +--
src/backend/replication/logical/reorderbuffer.c | 12 -------
src/backend/replication/walsender.c             | 43 ++-----------------------
src/include/catalog/catversion.h                |  2 +-
src/include/catalog/pg_proc.dat                 |  6 ++--
src/include/replication/reorderbuffer.h         | 11 -------
src/include/replication/walsender_private.h     |  5 ---
src/test/regress/expected/rules.out             |  7 ++--
9 files changed, 9 insertions(+), 120 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix timestamp range handling in regression tests of modules/comm
Next
From: Jeff Davis
Date:
Subject: pgsql: HashAgg: before spilling tuples, set unneeded columns to NULL.