pgsql: Morph pg_replication_slots.min_safe_lsn to safe_wal_size - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Morph pg_replication_slots.min_safe_lsn to safe_wal_size
Date
Msg-id E1jsr5w-0004aM-OT@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Morph pg_replication_slots.min_safe_lsn to safe_wal_size

The previous definition of the column was almost universally disliked,
so provide this updated definition which is more useful for monitoring
purposes: a large positive value is good, while zero or a negative value
means danger.  This should be operationally more convenient.

Backpatch to 13, where the new column to pg_replication_slots (and the
feature it represents) were added.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reported-by: Fujii Masao <masao.fujii@oss.nttdata.com>
Discussion: https://postgr.es/m/9ddfbf8c-2f67-904d-44ed-cf8bc5916228@oss.nttdata.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c54b5891f415df36809de1aeb97e4574d5456d69

Modified Files
--------------
doc/src/sgml/catalogs.sgml                |  7 ++++--
src/backend/access/transam/xlog.c         |  6 ++---
src/backend/catalog/system_views.sql      |  2 +-
src/backend/replication/slotfuncs.c       | 40 +++++++++++++++++++++++--------
src/include/access/xlog_internal.h        |  7 ++++++
src/include/catalog/catversion.h          |  2 +-
src/include/catalog/pg_proc.dat           |  4 ++--
src/test/recovery/t/019_replslot_limit.pl | 22 ++++++++---------
src/test/regress/expected/rules.out       |  4 ++--
9 files changed, 60 insertions(+), 34 deletions(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Check ssl_in_use flag when reporting statistics
Next
From: Tom Lane
Date:
Subject: pgsql: Don't create pg_type entries for sequences or toast tables.