Postgres Pro
Downloads
Home   >   mailing lists

pgAdmin 4 commit: Fixed following SonarQube issues: - Mailing list pgadmin-hackers

From Akshay Joshi
Subject pgAdmin 4 commit: Fixed following SonarQube issues:
Date
Msg-id E1jo2vB-0006Gr-9P@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Tree view 
Fixed following SonarQube issues:
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15c621b1d87aef43dfdf544f848987b9ec92d9ba

Modified Files
--------------
web/pgadmin/misc/static/explain/scss/_explain.scss |  5 ----
.../handle_query_output_keyboard_event.js          |  1 -
web/pgadmin/static/scss/_backform.overrides.scss   |  2 +-
web/pgadmin/static/scss/_bootstrap.overrides.scss  |  2 +-
web/pgadmin/static/scss/_pgadmin.style.scss        |  5 ++--
.../tools/debugger/static/js/debugger_ui.js        | 22 +++++++-------
.../tools/schema_diff/static/css/schema_diff.css   | 34 ----------------------
.../schema_diff/static/scss/_schema_diff.scss      | 21 +++++++++++++
8 files changed, 36 insertions(+), 56 deletions(-)

pgadmin-hackers by date:

Previous
From: Nikhil Mohite
Date:
Subject: Patch for SonarQube code scan.
Next
From: Akshay Joshi
Date:
Subject: Re: Patch for SonarQube code scan.