pgsql: Remove dead forceSync parameter of XactLogCommitRecord(). - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Remove dead forceSync parameter of XactLogCommitRecord().
Date
Msg-id E1jmYt5-0003gp-Bb@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove dead forceSync parameter of XactLogCommitRecord().

The function has been reading global variable forceSyncCommit, mirroring
the intent of the caller that passed forceSync=forceSyncCommit.  The
other caller, RecordTransactionCommitPrepared(), passed false.  Since
COMMIT PREPARED can't share a transaction with any command, it certainly
doesn't share a transaction with a command that sets forceSyncCommit.

Reviewed by Michael Paquier.

Discussion: https://postgr.es/m/20200617032615.GC2916904@rfd.leadboat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d28ab91e7155353d4377abad5a7d5b0f07450867

Modified Files
--------------
src/backend/access/transam/twophase.c | 2 +-
src/backend/access/transam/xact.c     | 8 +++++---
src/include/access/xact.h             | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Removal unused function parameter in CopyReadBinaryAttribute.
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Add documentation for opclass options