pgAdmin 4 commit: Fixed generated SQL issue for auto vacuum options. Fi - Mailing list pgadmin-hackers

Fixed generated SQL issue for auto vacuum options. Fixes #5398

Fixed some more issues:

 1) pgAdmin allows only true or false values for autovacuum_enabled,
    and there is no way to reset it individually without disabling a custom auto vacuum.
    To fix this, the control is changed from the switch to three state buttons.
 2) Setting any vacuum options to zero made the option disappear from the SQL.
 3) Right-click on a table with vacuum options set and create a new table.
 4) The parameters tab will have the options prefilled.
 5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
    The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b64896f558fb100a93c976cbffe7cc3d73632e47
Author: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>

Modified Files
--------------
docs/en_US/images/materialized_view_parameter.png  | Bin 95185 -> 114152 bytes
docs/en_US/images/table_parameter.png              | Bin 93061 -> 122363 bytes
docs/en_US/materialized_view_dialog.rst            |   7 +-
docs/en_US/release_notes_4_22.rst                  |   1 +
docs/en_US/table_dialog.rst                        |   4 +-
.../servers/databases/schemas/static/js/schema.js  |  88 +++------
.../servers/databases/schemas/tables/__init__.py   |  71 ++++---
.../tables/partitions/static/js/partition.js       |   4 +-
.../databases/schemas/tables/static/js/table.js    |  14 +-
.../partitions/sql/gpdb/5_plus/properties.sql      |   2 -
.../partitions/sql/pg/10_plus/properties.sql       |   6 -
.../partitions/sql/pg/12_plus/properties.sql       |   6 -
.../partitions/sql/ppas/10_plus/properties.sql     |   6 -
.../partitions/sql/ppas/12_plus/properties.sql     |   6 -
.../tables/templates/tables/sql/10_plus/create.sql |  14 +-
.../templates/tables/sql/10_plus/properties.sql    |  12 +-
.../tables/templates/tables/sql/11_plus/create.sql |  14 +-
.../templates/tables/sql/11_plus/properties.sql    |  12 +-
.../tables/templates/tables/sql/11_plus/update.sql |  32 +++-
.../tables/templates/tables/sql/12_plus/create.sql |  47 ++---
.../templates/tables/sql/12_plus/properties.sql    |  12 +-
.../tables/templates/tables/sql/12_plus/update.sql |  34 ++--
.../templates/tables/sql/9.1_plus/properties.sql   |  12 +-
.../templates/tables/sql/9.6_plus/create.sql       |  14 +-
.../templates/tables/sql/9.6_plus/properties.sql   |  12 +-
.../templates/tables/sql/9.6_plus/update.sql       |  32 +++-
.../tables/templates/tables/sql/default/create.sql |  14 +-
.../templates/tables/sql/default/properties.sql    |  12 +-
.../tables/templates/tables/sql/default/update.sql |  34 ++--
.../tables/sql/gpdb_5.0_plus/properties.sql        |   4 -
.../schemas/tables/tests/test_table_parameters.py  | 153 ++++++++++------
.../servers/databases/schemas/tables/utils.py      |  36 ++--
.../servers/databases/schemas/utils.py             |   6 +-
.../servers/databases/schemas/views/__init__.py    | 204 +++++++--------------
.../databases/schemas/views/static/js/mview.js     |  24 ++-
.../templates/mviews/pg/9.3_plus/sql/create.sql    |  14 +-
.../mviews/pg/9.3_plus/sql/properties.sql          |  10 +-
.../templates/mviews/pg/9.3_plus/sql/update.sql    |  88 ++++-----
.../templates/mviews/pg/9.4_plus/sql/create.sql    |  14 +-
.../mviews/pg/9.4_plus/sql/properties.sql          |  10 +-
.../templates/mviews/pg/9.4_plus/sql/update.sql    |  75 ++++----
.../templates/mviews/ppas/9.3_plus/sql/create.sql  |  14 +-
.../mviews/ppas/9.3_plus/sql/properties.sql        |  10 +-
.../templates/mviews/ppas/9.3_plus/sql/update.sql  |  75 ++++----
.../pg/9.4_plus/alter_mview_add_fillfactor.sql     |   3 +-
.../9.4_plus/alter_mview_add_table_parameter.sql   |   4 +-
.../alter_mview_add_table_parameter_msql.sql       |   4 +-
.../alter_mview_remove_table_parameter.sql         |   3 +-
.../alter_mview_remove_table_parameter_msql.sql    |   6 +-
.../views/tests/pg/9.4_plus/test_mview.json        |  58 +-----
.../ppas/9.4_plus/alter_mview_add_fillfactor.sql   |   3 +-
.../9.4_plus/alter_mview_add_table_parameter.sql   |   4 +-
.../alter_mview_add_table_parameter_msql.sql       |   4 +-
.../alter_mview_remove_table_parameter.sql         |   3 +-
.../alter_mview_remove_table_parameter_msql.sql    |   6 +-
.../views/tests/ppas/9.4_plus/test_mview.json      |  58 +-----
.../schemas/views/tests/test_mviews_parameters.py  | 153 ++++++++++------
57 files changed, 715 insertions(+), 853 deletions(-)