pgsql: Improve placement of "display name" comment in win32_tzmap[] ent - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve placement of "display name" comment in win32_tzmap[] ent
Date
Msg-id E1jS6Ge-0001wg-T4@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve placement of "display name" comment in win32_tzmap[] entries.

Sticking this comment at the end of the last line was a bad idea: it's
not particularly readable, and it tempts pgindent to mess with line
breaks within the comment, which in turn reveals that win32tzlist.pl's
clean_displayname() does the wrong thing to clean up such line breaks.
While that's not hard to fix, there's basically no excuse for this
arrangement to begin with, especially since it makes the table layout
needlessly vary across back branches with different pgindent rules.
Let's just put the comment inside the braces, instead.

This commit just moves and reformats the comments, and updates
win32tzlist.pl to match; there's no actual data change.

Per odd-looking results from Juan José Santamaría Flecha.
Back-patch, since the point is to make win32_tzmap[] look the
same in all supported branches again.

Discussion: https://postgr.es/m/5752.1587740484@sss.pgh.pa.us

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/351252904a8c5b674a508b7fa5c3924c66d1f7f6

Modified Files
--------------
src/bin/initdb/findtimezone.c | 441 +++++++++++++++++++++++++++---------------
src/tools/win32tzlist.pl      |  14 +-
2 files changed, 292 insertions(+), 163 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: update section 9.13 for new function table layout.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Fix handling of WAL segments ready to be archived duringcrash r