pgsql: Fix possible crash with GENERATED ALWAYS columns - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Fix possible crash with GENERATED ALWAYS columns
Date
Msg-id E1jPcwi-0004A0-CK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix possible crash with GENERATED ALWAYS columns

In some corner cases, this could also lead to corrupted values being
included in the tuple.

Users who are concerned that they are affected by this should first
upgrade and then perform a base backup of their database and restore onto
an off-line server. They should then query each table with generated
columns to ensure there are no rows where the generated expression does
not match a newly calculated version of the GENERATED ALWAYS expression.
If no crashes occur and no rows are returned then you're not affected.

Fixes bug #16369.

Reported-by: Cameron Ezell
Discussion: https://postgr.es/m/16369-5845a6f1bef59884@postgresql.org
Backpatch-through: 12 (where GENERATED ALWAYS columns were added.)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3cb02e307e350caf3c9099c6f661a95fd00e7e4c

Modified Files
--------------
src/backend/executor/nodeModifyTable.c  |  7 +++++++
src/test/regress/expected/generated.out | 12 ++++++++++++
src/test/regress/sql/generated.sql      |  7 +++++++
3 files changed, 26 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: revise formatting of function/operator tables.
Next
From: David Rowley
Date:
Subject: pgsql: Fix possible crash with GENERATED ALWAYS columns