pgsql: Further improve stability fix for partition_aggregate test. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Further improve stability fix for partition_aggregate test.
Date
Msg-id E1jKxI0-0000CW-3e@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Further improve stability fix for partition_aggregate test.

Commit 7cb0a423f overlooked that the multi-level partition test table
pagg_tab_ml still had an exactly even row split at its upper level of
partitioning, so that some of the sub-aggregation plan steps still had
exactly equal costs, leading to plan instability.  Tweak the partition
boundaries some more to make the row distribution unequal at both
levels.  This leads to more changes in the "expected" plan order than
the previous round, but it seems fine.  (Actually, I'm surprised that
this didn't affect even more plans in this test: looking at the
underlying costs shows that some of the parallel plan groups are
*not* getting sorted by cost.  Bug?)

Per buildfarm member lousyjack,
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2020-04-04%2021%3A03%3A04

Discussion: https://postgr.es/m/24467.1585838693@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/18d85e9b8a2b784bcee350c59cf20c5c697a1c1f

Modified Files
--------------
src/test/regress/expected/partition_aggregate.out | 64 +++++++++++------------
src/test/regress/sql/partition_aggregate.sql      |  4 +-
2 files changed, 34 insertions(+), 34 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Allow pg_stat_statements to track WAL usage statistics.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Save errno across LWLockRelease() calls