pgsql: Allow pg_stat_statements to track planning statistics. - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Allow pg_stat_statements to track planning statistics.
Date
Msg-id E1jJpUQ-0006vz-Bv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow pg_stat_statements to track planning statistics.

This commit makes pg_stat_statements support new GUC
pg_stat_statements.track_planning. If this option is enabled,
pg_stat_statements tracks the planning statistics of the statements,
e.g., the number of times the statement was planned, the total time
spent planning the statement, etc. This feature is useful to check
the statements that it takes a long time to plan. Previously since
pg_stat_statements tracked only the execution statistics, we could
not use that for the purpose.

The planning and execution statistics are stored at the end of
each phase separately. So there are not always one-to-one relationship
between them. For example, if the statement is successfully planned
but fails in the execution phase, only its planning statistics are stored.
This may cause the users to be able to see different pg_stat_statements
results from the previous version. To avoid this,
pg_stat_statements.track_planning needs to be disabled.

This commit bumps the version of pg_stat_statements to 1.8
since it changes the definition of pg_stat_statements function.

Author: Julien Rouhaud, Pascal Legrand, Thomas Munro, Fujii Masao
Reviewed-by: Sergei Kornilov, Tomas Vondra, Yoshikazu Imai, Haribabu Kommi, Tom Lane
Discussion: https://postgr.es/m/CAHGQGwFx_=DO-Gu-MfPW3VQ4qC7TfVdH2zHmvZfrGv6fQ3D-Tw@mail.gmail.com
Discussion: https://postgr.es/m/CAEepm=0e59Y_6Q_YXYCTHZkqOc6H2pJ54C_Xe=VFu50Aqqp_sA@mail.gmail.com
Discussion: https://postgr.es/m/DB6PR0301MB21352F6210E3B11934B0DCC790B00@DB6PR0301MB2135.eurprd03.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/17e03282241c6ac58a714eb0c3b6a8018cf6167a

Modified Files
--------------
contrib/pg_stat_statements/Makefile                |   3 +-
.../expected/pg_stat_statements.out                | 231 +++++++++++------
.../pg_stat_statements--1.7--1.8.sql               |  55 ++++
contrib/pg_stat_statements/pg_stat_statements.c    | 284 ++++++++++++++++-----
.../pg_stat_statements/pg_stat_statements.control  |   4 +-
.../pg_stat_statements/sql/pg_stat_statements.sql  |  16 ++
doc/src/sgml/pgstatstatements.sgml                 | 232 +++++++++++------
src/tools/pgindent/typedefs.list                   |   1 +
8 files changed, 603 insertions(+), 223 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pgsql: Allow vacuum command to process indexes in parallel.
Next
From: Amit Kapila
Date:
Subject: pgsql: Allow parallel vacuum to accumulate buffer usage.