pgsql: Be more careful about extracting encoding from locale strings on - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Be more careful about extracting encoding from locale strings on
Date
Msg-id E1jIw8E-0001mu-Ml@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Be more careful about extracting encoding from locale strings on Windows.

GetLocaleInfoEx() can fail on strings that setlocale() was perfectly
happy with.  A common way for that to happen is if the locale string
is actually a Unix-style string, say "et_EE.UTF-8".  In that case,
what's after the dot is an encoding name, not a Windows codepage number;
blindly treating it as a codepage number led to failure, with a fairly
silly error message.  Hence, check to see if what's after the dot is
all digits, and if not, treat it as a literal encoding name rather than
a codepage number.  This will do the right thing with many Unix-style
locale strings, and produce a more sensible error message otherwise.

Somewhat independently of that, treat a zero (CP_ACP) result from
GetLocaleInfoEx() as meaning that we must use UTF-8 encoding.

Back-patch to all supported branches.

Juan José Santamaría Flecha

Discussion: https://postgr.es/m/24905.1585445371@sss.pgh.pa.us

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6dac1e858b12c1fe67fcd72db4476210177e24c1

Modified Files
--------------
src/port/chklocale.c | 30 ++++++++++++++++++++++++------
1 file changed, 24 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Rémi Zara
Date:
Subject: Re: pgsql: Add kqueue(2) support to the WaitEventSet API.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Allow using Unix-domain sockets on Windows in tests