pgsql: Add prefix checks in exclude lists for pg_rewind, pg_checksums a - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Add prefix checks in exclude lists for pg_rewind, pg_checksums a
Date
Msg-id E1j69pd-0007mJ-71@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add prefix checks in exclude lists for pg_rewind, pg_checksums and base backups

An instance of PostgreSQL crashing with a bad timing could leave behind
temporary pg_internal.init files, potentially causing failures when
verifying checksums.  As the same exclusion lists are used between
pg_rewind, pg_checksums and basebackup.c, all those tools are extended
with prefix checks to keep everything in sync, with dedicated checks
added for pg_internal.init.

Backpatch down to 11, where pg_checksums (pg_verify_checksums in 11) and
checksum verification for base backups have been introduced.

Reported-by: Michael Banck
Author: Michael Paquier
Reviewed-by: Kyotaro Horiguchi, David Steele
Discussion: https://postgr.es/m/62031974fd8e941dd8351fbc8c7eff60d59c5338.camel@credativ.de
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bf883b211eae18662f2dfaede02f5d115bf0b805

Modified Files
--------------
src/backend/replication/basebackup.c         | 75 ++++++++++++++++++----------
src/bin/pg_basebackup/t/010_pg_basebackup.pl |  8 +--
src/bin/pg_checksums/pg_checksums.c          | 39 +++++++++++----
src/bin/pg_checksums/t/002_actions.pl        |  4 +-
src/bin/pg_rewind/filemap.c                  | 43 +++++++++++-----
5 files changed, 116 insertions(+), 53 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Factor out InitControlFile() from BootStrapXLOG()
Next
From: Robert Haas
Date:
Subject: pgsql: Move bitmap_hash and bitmap_match to bitmapset.c.