pg_upgrade: Fix quoting of some arguments in pg_ctl command
The previous coding forgot to apply shell quoting to the socket
directory and the data folder, leading to failures when running
pg_upgrade. This refactors the code generating the pg_ctl command
starting clusters to use a more correct shell quoting. Failures are
easier to trigger in 12 and newer versions by using a value of
--socketdir that includes quotes, but it is also possible to cause
failures with quotes included in the default socket directory used by
pg_upgrade or the data folders of the clusters involved in the
upgrade.
As 9.4 is going to be EOL'd with the next minor release, nobody is
likely going to upgrade to it now so this branch is not included in the
set of branches fixed.
Author: Michael Paquier
Reviewed-by: Álvaro Herrera, Noah Misch
Backpatch-through: 9.5
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d1c0b6132839e496eea73383813a127833af72f1
Modified Files
--------------
src/bin/pg_upgrade/server.c | 96 +++++++++++++++++++++++++++++++--------------
1 file changed, 67 insertions(+), 29 deletions(-)
