pgsql: Fix assorted error-cleanup bugs in SSL min/max protocol version - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix assorted error-cleanup bugs in SSL min/max protocol version
Date
Msg-id E1iyJgj-0000qu-Nb@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix assorted error-cleanup bugs in SSL min/max protocol version code.

The error exits added to initialize_SSL() failed to clean up the
partially-built SSL_context, and some of them also leaked the
result of SSLerrmessage().  Make them match other error-handling
cases in that function.

The error exits added to connectOptions2() failed to set conn->status
like every other error exit in that function.

In passing, make the SSL_get_peer_certificate() error exit look more
like all the other calls of SSLerrmessage().

Oversights in commit ff8ca5fad.  Coverity whined about leakage of the
SSLerrmessage() results; I noted the rest in manual code review.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6148e2b9a6399b77e10e277c32d701b84703820f

Modified Files
--------------
src/interfaces/libpq/fe-connect.c        |  3 +++
src/interfaces/libpq/fe-secure-openssl.c | 10 +++++++---
2 files changed, 10 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Gierth
Date:
Subject: pgsql: Optimizations for integer to decimal output.
Next
From: Fujii Masao
Date:
Subject: pgsql: Revert commit 56bc82a511.