pgAdmin 4 commit: Fixed following schema diff issues: - Mailing list pgadmin-hackers

Fixed following schema diff issues:
  1) Version mismatch should be displayed if you select EPAS 11 as the source and EPAS 12 as the target.
  2) We should handle schema diff if the user stops the server after compare.
  3) The data type is not visible for column headers in the query tool/view data.
  4) Difference SQL is shown, though source & target SQL are same.
  5) Error is shown when the 'target only' table is selected & clicked on Generate Script.
  6) Difference SQL generated on deleting primary constraints from source throwing error on running from query tool.
  7) Copy button for Difference SQL does not work.
  8) Incorrect SQL is generated when check constraint from the source table is dropped.
  9) Difference SQL is NOT shown when 'Unique Constraint' is dropped from the source table.
 10) In case of difference, no message displayed related to copied successfully or not.
 11) create or replace trigger should be on the next line.
 12) Comparison Result of exactly identical tables having foreign key constraints is shown as different.
 13) The wrong SQL displayed in the difference tab for view and materialized view for the select statements.
 14) Wrong SQL displayed for the procedure in the difference section.
 15) If the user already opens the compare section of Schema diff tool and Disconnects the server then '<' not
supportedbetween instances of 'NoneType' and 'int' message displayed. 
 16) When 'check constraint' is added on the source table which has already unique constraint & identical target table
iscreated, all SQL panels remain empty. 
 17) Difference SQL is NOT shown when after adding 'Foreign Key' constraint to existing source table.
 18) Incorrect SQL is generated when the existing index on the source table is modified.
 19) Wrong SQL displayed for function in difference section.
 20) Additional space is added before & after in difference SQL generated on the addition of an index to the source
table.
 21) Difference SQL is NOT shown when tables have different permission/grants.
 22) Incorrect SQL is shown when the source had inherited table & target has a normal table.
 23) Exactly identical child(inherited) tables show difference SQL.
 24) Comparison is NOT working when the custom vacuum is enabled & one of the parameter modified & again custom vacuum
isdisabled. 

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c418a9c9ca251c178ea66047b1385f7d45d21f9f
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>

Modified Files
--------------
.../templates/functions/pg/sql/11_plus/update.sql  |  2 +-
.../templates/functions/pg/sql/12_plus/update.sql  |  2 +-
.../templates/functions/pg/sql/9.2_plus/update.sql |  2 +-
.../templates/functions/pg/sql/9.5_plus/update.sql |  2 +-
.../templates/functions/pg/sql/9.6_plus/update.sql |  2 +-
.../templates/functions/pg/sql/default/update.sql  |  2 +-
.../functions/ppas/sql/12_plus/update.sql          |  2 +-
.../functions/ppas/sql/9.2_plus/update.sql         |  2 +-
.../functions/ppas/sql/9.5_plus/update.sql         |  2 +-
.../functions/ppas/sql/9.6_plus/update.sql         |  2 +-
.../functions/ppas/sql/default/update.sql          |  2 +-
.../templates/procedures/pg/sql/11_plus/update.sql |  2 +-
.../procedures/ppas/sql/11_plus/update.sql         |  2 +-
.../servers/databases/schemas/packages/__init__.py |  1 -
.../servers/databases/schemas/tables/__init__.py   | 19 ++++-
.../tables/constraints/check_constraint/utils.py   |  1 +
.../tables/constraints/index_constraint/utils.py   | 24 ++++--
.../databases/schemas/tables/indexes/__init__.py   | 54 ++++++++++----
.../databases/schemas/tables/schema_diff_utils.py  | 36 ++++-----
.../templates/columns/sql/10_plus/update.sql       |  2 +-
.../templates/indexes/sql/default/update.sql       |  2 +-
.../servers/databases/schemas/tables/utils.py      | 22 ++++--
web/pgadmin/tools/schema_diff/__init__.py          | 19 +++--
web/pgadmin/tools/schema_diff/directory_compare.py | 86 ++++++++++++----------
.../tools/schema_diff/static/css/schema_diff.css   |  2 +-
.../schema_diff/static/js/schema_diff.backform.js  | 20 ++---
.../tools/schema_diff/static/js/schema_diff.js     |  4 +-
.../tools/schema_diff/static/js/schema_diff_ui.js  | 10 ++-
28 files changed, 200 insertions(+), 128 deletions(-)