pgsql: Fix collation exposed for scalar function in FROM. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix collation exposed for scalar function in FROM.
Date
Msg-id E1in5Wm-0004QZ-R1@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix collation exposed for scalar function in FROM.

One code path in addRangeTableEntryForFunction() neglected to assign
a collation to the tupdesc entry it constructs (which is a bit odd
considering the other path did do so).  This didn't matter before commit
5815696bc, because nothing would look at the type data in this tupdesc;
but now it does.

While at it, make sure we assign the correct typmod as well.  Most
function expressions don't have a determinate typmod, but some do.

Per buildfarm, which showed failures in non-C collations, a case
I'd not thought to test for this patch :-(

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4d02eb017e3c1268762fd1a10ec3c569515c047d

Modified Files
--------------
src/backend/parser/parse_relation.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Update copyrights for 2020
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str