pgsql: Change overly strict Assert in TransactionGroupUpdateXidStatus. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Change overly strict Assert in TransactionGroupUpdateXidStatus.
Date
Msg-id E1ih4PO-00027u-0N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Change overly strict Assert in TransactionGroupUpdateXidStatus.

This Assert thought that an overflowed transaction can never get registered
for the group update.  But that is not true, because even when the number
of children for a transaction got reduced, the overflow flag is not
changed.  And, for group update, we only care about the current number of
children for a transaction that is being committed.

Based on comments by Andres Freund, remove a redundant Assert in
TransactionIdSetPageStatus as we already had a static Assert for the same
condition a few lines earlier.

Reported-by: Vignesh C
Author: Dilip Kumar
Reviewed-by: Amit Kapila
Backpatch-through: 11
Discussion: https://postgr.es/m/CAFiTN-s5=uJw-Z6JC9gcqtBSjXsrHnU63PXBrA=pnBjqnkm5UA@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0eac283bfc8b893d91a1ecf184d2c8373a1ed906

Modified Files
--------------
src/backend/access/transam/clog.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Change overly strict Assert in TransactionGroupUpdateXidStatus.
Next
From: Robert Haas
Date:
Subject: pgsql: Move interrupt-handling code into subroutines.