pgsql: Improve stability of tests for VACUUM (SKIP_LOCKED) - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve stability of tests for VACUUM (SKIP_LOCKED)
Date
Msg-id E1iVrVN-0003vF-JD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve stability of tests for VACUUM (SKIP_LOCKED)

Concurrent autovacuums running with the main regression test suite
could cause the tests with VACUUM (SKIP_LOCKED) to generate randomly
WARNING messages.  For these tests, set client_min_messages to ERROR to
get rid of those random failures, as disabling autovacuum for the
relations operated would not completely close the failure window.

For isolation tests, disable autovacuum for the relations vacuumed with
SKIP_LOCKED.  The tests are designed so as LOCK commands are taken
in a first session before running a concurrent VACUUM (SKIP_LOCKED) in a
second to generate WARNING messages, but a concurrent autovacuum could
cause the tests to be slower.

Reported-by: Tom Lane
Author: Michael Paquier
Reviewed-by: Andres Freund, Tom Lane
Discussion: https://postgr.es/m/25294.1573077278@sss.pgh.pa.us
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bbaa38e824236ac106fffbf5f61e5da9b3dc1ec9

Modified Files
--------------
src/test/isolation/specs/vacuum-skip-locked.spec | 2 ++
src/test/regress/expected/vacuum.out             | 5 ++++-
src/test/regress/sql/vacuum.sql                  | 5 ++++-
3 files changed, 10 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Properly determine length for on-disk TOAST values
Next
From: Peter Geoghegan
Date:
Subject: Re: pgsql: Add tests for tuplesort.c.