pgsql: Have LookupFuncName accept NULL argtypes for 0 args - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Have LookupFuncName accept NULL argtypes for 0 args
Date
Msg-id E1iUcRm-0005Vo-Lx@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Have LookupFuncName accept NULL argtypes for 0 args

Prior to this change, it requires to be passed a valid pointer just to
be able to pass it to a zero-byte memcmp, per 0a52d378b03b.  Given the
strange resulting code in callsites, it seems better to test for the
case specifically and remove the requirement.

Reported-by: Ranier Vilela
Discussion: https://postgr.es/m/MN2PR18MB2927F24692485D754794F01BE3740@MN2PR18MB2927.namprd18.prod.outlook.com
Discussion: https://postgr.es/m/MN2PR18MB2927F6873DF2774A505AC298E3740@MN2PR18MB2927.namprd18.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dcb7d3cafa3197c5425c129ba0dc5eddd23c0532

Modified Files
--------------
src/backend/commands/event_trigger.c | 3 +--
src/backend/commands/foreigncmds.c   | 3 +--
src/backend/commands/proclang.c      | 4 ++--
src/backend/commands/trigger.c       | 3 +--
src/backend/parser/parse_func.c      | 8 +++++---
src/pl/tcl/pltcl.c                   | 3 +--
6 files changed, 11 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Teach datum_image_eq() about cstring datums.
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Make _bt_keep_natts_fast() use datum_image_eq().