pgsql: Refactor code building relation options - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Refactor code building relation options
Date
Msg-id E1iRmY2-0004gU-61@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Refactor code building relation options

Historically, the code to build relation options has been shaped the
same way in multiple code paths by using a set of datums in input with
the options parsed with a static table which is then filled with the
option values.  This introduces a new common routine in reloptions.c to
do most of the legwork for the in-core code paths.

Author: Amit Langote
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CA+HiwqGsoSn_uTPPYT19WrtR7oYpYtv4CdS0xuedTKiHHWuk_g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3534fa2233285c1fab1e668871aabf05e5541213

Modified Files
--------------
contrib/bloom/blutils.c                          |  14 +--
src/backend/access/brin/brin.c                   |  22 +----
src/backend/access/common/reloptions.c           | 115 +++++++++++------------
src/backend/access/gin/ginutil.c                 |  22 +----
src/backend/access/gist/gistutil.c               |  22 +----
src/include/access/reloptions.h                  |   5 +
src/test/modules/dummy_index_am/dummy_index_am.c |  15 +--
7 files changed, 82 insertions(+), 133 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Stabilize pg_dump output order for similarly-named triggers and
Next
From: Michael Paquier
Date:
Subject: pgsql: Doc: Improve description around ALTER TABLE ATTACH PARTITION