pgsql: Fix some minor spec-compliance issues in jsonpath lexer. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix some minor spec-compliance issues in jsonpath lexer.
Date
Msg-id E1iBNYg-0000w7-29@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix some minor spec-compliance issues in jsonpath lexer.

Although the SQL/JSON tech report makes reference to ECMAScript which
allows both single- and double-quoted strings, all the rest of the
report speaks only of double-quoted string literals in jsonpaths.
That's more compatible with JSON itself; moreover single-quoted strings
are hard to use inside a jsonpath that is itself a single-quoted SQL
literal.  So guess that the intent is to allow only double-quoted
literals, and remove lexer support for single-quoted literals.
It'll be less painful to add this again later if we're wrong, than to
remove a shipped feature.

Also, adjust the lexer so that unrecognized backslash sequences are
treated as just meaning the escaped character, not as errors.  This
change has much better support in the standards, as JSON, JavaScript
and ECMAScript all make it plain that that's what's supposed to
happen.

Back-patch to v12.

Discussion: https://postgr.es/m/CAPpHfdvDci4iqNF9fhRkTqhe-5_8HmzeLt56drH%2B_Rv2rNRqfg@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5f3bec0769c1d3c345ee2de30de271dce4feb469

Modified Files
--------------
src/backend/utils/adt/jsonpath_scan.l             | 79 +++++++++--------------
src/test/regress/expected/jsonpath.out            | 18 ++----
src/test/regress/expected/jsonpath_encoding.out   | 78 ----------------------
src/test/regress/expected/jsonpath_encoding_1.out | 72 ---------------------
src/test/regress/sql/jsonpath.sql                 |  3 +-
src/test/regress/sql/jsonpath_encoding.sql        | 23 -------
6 files changed, 38 insertions(+), 235 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Revert "Add DECLARE STATEMENT support to ECPG."
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Optimize get_jsonb_path_all avoiding an iterator