pgsql: amcheck: Skip unlogged relations during recovery. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: amcheck: Skip unlogged relations during recovery.
Date
Msg-id E1hxIhH-0006X9-UC@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
amcheck: Skip unlogged relations during recovery.

contrib/amcheck failed to consider the possibility that unlogged
relations will not have any main relation fork files when running in hot
standby mode.  This led to low-level "can't happen" errors that complain
about the absence of a relfilenode file.

To fix, simply skip verification of unlogged index relations during
recovery.  In passing, add a direct check for the presence of a main
fork just before verification proper begins, so that we cleanly verify
the presence of the main relation fork file.

Author: Andrey Borodin, Peter Geoghegan
Reported-By: Andrey Borodin
Diagnosed-By: Andrey Borodin
Discussion: https://postgr.es/m/DA9B33AC-53CB-4643-96D4-7A0BBC037FA1@yandex-team.ru
Backpatch: 10-, where amcheck was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6754fe65a4c68c1e3b179080ab62c2f3ff6d877c

Modified Files
--------------
contrib/amcheck/verify_nbtree.c | 45 ++++++++++++++++++++++++++++++++++++-----
1 file changed, 40 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix compiler warning
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix random regression failure in test case "temp"