Fix predicate-locking of HOT updated rows.
In serializable mode, heap_hot_search_buffer() incorrectly acquired a
predicate lock on the root tuple, not the returned tuple that satisfied
the visibility checks. As explained in README-SSI, the predicate lock does
not need to be copied or extended to other tuple versions, but for that to
work, the correct, visible, tuple version must be locked in the first
place.
The original SSI commit had this bug in it, but it was fixed back in 2013,
in commit 81fbbfe335. But unfortunately, it was reintroduced a few months
later in commit b89e151054. Wising up from that, add a regression test
to cover this, so that it doesn't get reintroduced again. Also, move the
code that sets 't_self', so that it happens at the same time that the
other HeapTuple fields are set, to make it more clear that all the code in
the loop operate on the "current" tuple in the chain, not the root tuple.
Bug spotted by Andres Freund, analysis and original fix by Thomas Munro,
test case and some additional changes to the fix by Heikki Linnakangas.
Backpatch to all supported versions (9.4).
Discussion: https://www.postgresql.org/message-id/20190731210630.nqhszuktygwftjty%40alap3.anarazel.de
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f8d30182b121f0c38695498d6d386ffa96858e76
Modified Files
--------------
src/backend/access/heap/heapam.c | 29 +++++++----------
.../expected/predicate-lock-hot-tuple.out | 20 ++++++++++++
src/test/isolation/isolation_schedule | 1 +
.../isolation/specs/predicate-lock-hot-tuple.spec | 37 ++++++++++++++++++++++
4 files changed, 70 insertions(+), 17 deletions(-)
