pgsql: Revert "Add log_statement_sample_rate parameter" - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Revert "Add log_statement_sample_rate parameter"
Date
Msg-id E1huOD8-0007lB-8W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Add log_statement_sample_rate parameter"

This reverts commit 88bdbd3f746049834ae3cc972e6e650586ec3c9d.

As committed, statement sampling used the existing duration threshold
(log_min_duration_statement) when decide which statements to sample.
The issue is that even the longest statements are subject to sampling,
and so may not end up logged. An improvement was proposed, introducing
a second duration threshold, but it would not be backwards compatible.
So we've decided to revert this feature - the separate threshold should
be part of the feature itself.

Discussion: https://postgr.es/m/CAFj8pRDS8tQ3Wviw9%3DAvODyUciPSrGeMhJi_WPE%2BEB8%2B4gLL-Q%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/75506195da81d75597a4025b72f8367e6c45f60d

Modified Files
--------------
doc/src/sgml/config.sgml                      | 34 +++++----------------------
src/backend/tcop/postgres.c                   | 16 ++-----------
src/backend/utils/misc/guc.c                  | 15 +-----------
src/backend/utils/misc/postgresql.conf.sample | 12 ++++------
src/include/utils/guc.h                       |  1 -
5 files changed, 13 insertions(+), 65 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Revert "Silence compiler warning"
Next
From: Tom Lane
Date:
Subject: pgsql: Adjust v12 release notes for reversion oflog_statement_sample_r