pgsql: Fix loss of fractional digits for large values incash_numeric() - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix loss of fractional digits for large values incash_numeric()
Date
Msg-id E1hr2eE-0004RF-RZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix loss of fractional digits for large values in cash_numeric().

Money values exceeding about 18 digits (depending on lc_monetary)
could be inaccurately converted to numeric, due to select_div_scale()
deciding it didn't need to compute any fractional digits.  Force
its hand by setting the dscale of one division input to equal the
number of fractional digits we need.

In passing, rearrange the logic to not do useless work in locales
where money values are considered integral.

Per bug #15925 from Slawomir Chodnicki.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/15925-da9953e2674bb5c8@postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fa854112fc3d5fae1da071bd647eb777eb584c2e

Modified Files
--------------
src/backend/utils/adt/cash.c        | 58 ++++++++++++++++++++++++-------------
src/test/regress/expected/money.out | 16 +++++++++-
src/test/regress/sql/money.sql      |  6 +++-
3 files changed, 58 insertions(+), 22 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Make libpq documentation navigable between functions
Next
From: Tom Lane
Date:
Subject: pgsql: Tweak our special-case logic for the IANA "Factory" timezone.