pgsql: Improve stability of TAP test for synchronous replication - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve stability of TAP test for synchronous replication
Date
Msg-id E1hq6VT-0002qU-AT@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve stability of TAP test for synchronous replication

Slow buildfarm machines have run into issues with this TAP test caused
by a race condition related to the startup of a set of standbys, where
it is possible to finish with an unexpected order in the WAL sender
array of the primary.

This closes the race condition by making sure that any standby started
is registered into the WAL sender array of the primary before starting
the next one based on lookups of pg_stat_replication.

Backpatch down to 9.6 where the test has been introduced.

Author: Michael Paquier
Reviewed-by: Álvaro Herrera, Noah Misch
Discussion: https://postgr.es/m/20190617055145.GB18917@paquier.xyz
Backpatch-through: 9.6

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/46fb7ff65ec29f7aab2e479ab43a180d67a267ed

Modified Files
--------------
src/test/recovery/t/007_sync_rep.pl | 42 +++++++++++++++++++++++++++++--------
1 file changed, 33 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Check that partitions are not in use when dropping constraints
Next
From: Michael Paquier
Date:
Subject: pgsql: Doc: Clarify interactions of pg_receivexlog with remote_apply