pgsql: Adjust overly strict Assert - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Adjust overly strict Assert
Date
Msg-id E1hpKLN-0006ke-EG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Adjust overly strict Assert

3373c7155 changed how we determine EquivalenceClasses for relations and
added an Assert to ensure all relations mentioned in each EC's ec_relids
was a RELOPT_BASEREL.  However, the join removal code may remove a LEFT
JOIN and since it does not clean up EC members belonging to the removed
relations it can leave RELOPT_DEADREL rels in ec_relids.

Fix this by adjusting the Assert to allow RELOPT_DEADREL rels too.

Reported-by: sqlsmith via Andreas Seltenreich
Discussion: https://postgr.es/m/87y30r8sls.fsf@ansel.ydns.eu

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e1a0f6a983068675813074847e1d0d61bd37ac0e

Modified Files
--------------
src/backend/optimizer/path/equivclass.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove no-longer-helpful reliance on fixed-size local array.
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix inconsistencies and typos in the tree