pgsql: Unwind some workarounds for lack of portable int64 formatspecif - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Unwind some workarounds for lack of portable int64 formatspecif
Date
Msg-id E1hj3Fx-0005qW-P5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Unwind some workarounds for lack of portable int64 format specifier

Because there is no portable int64/uint64 format specifier and we
can't stick macros like INT64_FORMAT into the middle of a translatable
string, we have been using various workarounds that put the number to
be printed into a string buffer first.  Now that we always use our own
sprintf(), we can rely on %lld and %llu to work, so we can use those.

This patch undoes this workaround in a few places where it was
egregiously verbose.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion:
https://www.postgresql.org/message-id/flat/CAH2-Wz%3DWbNxc5ob5NJ9yqo2RMJ0q4HXDS30GVCobeCvC9A1L9A%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6a1cd8b9236dcfa91b40af3a8337859e16ba7113

Modified Files
--------------
src/backend/access/transam/xlogreader.c | 16 +++-------------
src/backend/replication/basebackup.c    | 11 +++--------
src/bin/pg_controldata/pg_controldata.c | 12 ++----------
src/bin/pg_resetwal/pg_resetwal.c       | 13 ++-----------
src/bin/pg_rewind/libpq_fetch.c         | 10 ++--------
src/bin/pg_test_timing/pg_test_timing.c | 12 +++---------
6 files changed, 15 insertions(+), 59 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Sync our Snowball stemmer dictionaries with current upstream
Next
From: Tomas Vondra
Date:
Subject: pgsql: Speed-up build of MCV lists with many distinct values