pgsql: Fix incorrect index behavior in COPY FROM with partitionedtable - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Fix incorrect index behavior in COPY FROM with partitionedtable
Date
Msg-id E1hYPWa-0006kx-T3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix incorrect index behavior in COPY FROM with partitioned tables

86b85044e rewrote how COPY FROM works to allow multiple tuple buffers to
exist to once thus allowing multi-inserts to be used in more cases with
partitioned tables.  That commit neglected to update the estate's
es_result_relation_info when flushing the insert buffer to the partition
making it possible for the index tuples to be added into an index on the
wrong partition.

Fix this and also add an Assert in ExecInsertIndexTuples to help ensure
that we never make this mistake again.

Reported-by: Haruka Takatsuka
Author: Ashutosh Sharma
Discussion: https://postgr.es/m/15832-b1bf336a4ee246b5@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/56b3b3838284f53c83556592e60688522155f57f

Modified Files
--------------
src/backend/commands/copy.c         |  3 +++
src/backend/executor/execIndexing.c |  3 +++
src/test/regress/input/copy.source  | 13 +++++++++++++
src/test/regress/output/copy.source | 17 +++++++++++++++++
4 files changed, 36 insertions(+)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Rework code using list_delete_cell() in MergeAttributes
Next
From: David Rowley
Date:
Subject: pgsql: Fix confusing NOTICE text in REINDEX CONCURRENTLY