pgsql: Un-break ecpg tests for Windows. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Un-break ecpg tests for Windows.
Date
Msg-id E1hXSB1-00005G-GP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Un-break ecpg tests for Windows.

Declaring a function "inline" still doesn't work with Windows compilers
(C99? what's that?), unless the macro provided by pg_config.h is
in-scope, which it is not in our ECPG test programs.  So the workaround
I tried to use in commit 7640f9312 doesn't work for Windows.  Revert
the change in printf_hack.h, and instead just blacklist that file
in cpluspluscheck --- since it's a not-installed test file, we don't
really need to verify its C++ cleanliness anyway.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/10a53cae9993abae159abdc6a76e46f6aac120d1

Modified Files
--------------
src/interfaces/ecpg/test/expected/compat_informix-dec_test.c | 2 +-
src/interfaces/ecpg/test/expected/pgtypeslib-num_test.c      | 2 +-
src/interfaces/ecpg/test/expected/pgtypeslib-num_test2.c     | 2 +-
src/interfaces/ecpg/test/printf_hack.h                       | 2 +-
src/tools/pginclude/cpluspluscheck                           | 2 ++
5 files changed, 6 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Increase test coverage for worker_spi by ∞%
Next
From: Tom Lane
Date:
Subject: pgsql: Clean up PL/Perl's handling of the _() macro.