pgsql: Avoid "invalid memory alloc request size" while readingpg_stat_ - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid "invalid memory alloc request size" while readingpg_stat_
Date
Msg-id E1hO2Ei-0005Ec-KE@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid "invalid memory alloc request size" while reading pg_stat_activity.

On a 64-bit machine, if you set track_activity_query_size and
max_connections such that their product exceeds 1GB, shared memory
setup will still succeed (given enough RAM), but attempts to read
pg_stat_activity fail with "invalid memory alloc request size".
Work around that by using MemoryContextAllocHuge to allocate the
local copy of the activity strings.  Using the "huge" API costs us
nothing extra in normal cases, and it seems better than throwing
an error and/or explaining to people why they can't do this.

This situation seems insanely profligate today, but who knows what
people will consider normal in ten or twenty years?  So let's fix it
in HEAD but not worry about a back-patch.

Per report from James Tomson.

Discussion: https://postgr.es/m/1CFDCCD6-B268-48D8-85C8-400D2790B2C3@pushd.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8d0ddccec6366a2851da7d350b33659203aa644b

Modified Files
--------------
src/backend/postmaster/pgstat.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: pgsql: docs: fist draft version of the PG 12 release notes
Next
From: Magnus Hagander
Date:
Subject: pgsql: Fix typos and clarify a comment