pgsql: Remove duplicative polygon SP-GiST sequencing test. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove duplicative polygon SP-GiST sequencing test.
Date
Msg-id E1hEeYE-0001p1-Dy@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove duplicative polygon SP-GiST sequencing test.

Code coverage comparisons confirm that the tests using
quad_poly_tbl_ord_seq1/quad_poly_tbl_ord_idx1 hit no code
paths not also covered by the similar tests using
quad_poly_tbl_ord_seq2/quad_poly_tbl_ord_idx2.  Since these
test cases are pretty expensive, they need to contribute more
than zero benefit.

In passing, make quad_poly_tbl_ord_seq2 a temp table, since
there seems little reason to keep it around after the test.

Discussion: https://postgr.es/m/735.1554935715@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4aaa3b5cf1c33d713b8eefa3612a9112cbcf1074

Modified Files
--------------
src/test/regress/expected/polygon.out      | 27 +--------------------------
src/test/regress/expected/sanity_check.out |  2 --
src/test/regress/sql/polygon.sql           | 21 +--------------------
3 files changed, 2 insertions(+), 48 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: adjust libpq wording to be neither/nor
Next
From: Michael Meskes
Date:
Subject: pgsql: Fix off-by-one check that can lead to a memory overflow inecpg.