pgsql: tableam: Add table_finish_bulk_insert(). - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: tableam: Add table_finish_bulk_insert().
Date
Msg-id E1hB4k4-0000Y0-4s@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
tableam: Add table_finish_bulk_insert().

This replaces the previous calls of heap_sync() in places using
bulk-insert. By passing in the flags used for bulk-insert the AM can
decide (first at insert time and then during the finish call) which of
the optimizations apply to it, and what operations are necessary to
finish a bulk insert operation.

Also change HEAP_INSERT_* flags to TABLE_INSERT, and rename hi_options
to ti_options.

These changes are made even in copy.c, which hasn't yet been converted
to tableam. There's no harm in doing so.

Author: Andres Freund
Discussion: https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d45e40158623baacd3f36f92a670d435cc1e845f

Modified Files
--------------
src/backend/access/heap/heapam_handler.c | 12 +++++++++++
src/backend/commands/copy.c              | 35 ++++++++++++++------------------
src/backend/commands/createas.c          | 14 ++++++-------
src/backend/commands/matview.c           | 15 +++++++-------
src/backend/commands/tablecmds.c         | 16 +++++++--------
src/include/access/tableam.h             | 32 ++++++++++++++++++++++++++++-
6 files changed, 78 insertions(+), 46 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Restrict pgbench's zipfian parameter to ensure goodperformance.
Next
From: Andres Freund
Date:
Subject: pgsql: Only allow heap in a number of contrib modules.