pgsql: Correct obsolete nbtree page split comment. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Correct obsolete nbtree page split comment.
Date
Msg-id E1h3r4W-0005cA-8L@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Correct obsolete nbtree page split comment.

Commit 40dae7ec537, which made the nbtree page split algorithm more
robust, made _bt_insert_parent() only unlock the right child of the
parent page before inserting a new downlink into the parent.  Update a
comment from the Berkeley days claiming that both left and right child
pages are unlocked before the new downlink actually gets inserted.

The claim that it is okay to release both locks early based on Lehman
and Yao's say-so never made much sense.  Lehman and Yao must sometimes
"couple" buffer locks across a pair of internal pages when relocating a
downlink, unlike the corresponding code within _bt_getstack().

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f34283973a342aa1cb709d6e8f5cea430efcf29

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add support for hyperbolic functions, as well as log10().
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix cross-version compatibility checks of pg_verify_checksums