pgsql: Improve planner's understanding of strictness of typecoercions. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve planner's understanding of strictness of typecoercions.
Date
Msg-id E1gwXi9-00076a-Bg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve planner's understanding of strictness of type coercions.

PG type coercions are generally strict, ie a NULL input must produce
a NULL output (or, in domain cases, possibly an error).  The planner's
understanding of that was a bit incomplete though, so improve it:

* Teach contain_nonstrict_functions() that CoerceViaIO can always be
considered strict.  Previously it believed that only if the underlying
I/O functions were marked strict, which is often but not always true.

* Teach clause_is_strict_for() that CoerceViaIO, ArrayCoerceExpr,
ConvertRowtypeExpr, CoerceToDomain can all be considered strict.
Previously it knew nothing about any of them.

The main user-visible impact of this is that IS NOT NULL predicates
can be proven to hold from expressions involving casts in more cases
than before, allowing partial indexes with such predicates to be used
without extra pushups.  This reduces the surprise factor for users,
who may well be used to ordinary (function-call-based) casts being
known to be strict.

Per a gripe from Samuel Williams.  This doesn't rise to the level of
a bug, IMO, so no back-patch.

Discussion: https://postgr.es/m/27571.1550617881@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e04a3905e4f2e93bbd8fca08c3baeed7b15a48cf

Modified Files
--------------
src/backend/optimizer/util/clauses.c  | 10 ++++++++++
src/backend/optimizer/util/predtest.c | 21 +++++++++++++++++++++
2 files changed, 31 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix incorrect strictness test for ArrayCoerceExpr expressions.
Next
From: Andrew Gierth
Date:
Subject: pgsql: Use an unsigned char for bool if we don't use the native bool.