pgsql: Mark correctly initial slot snapshots with MVCC type when built - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Mark correctly initial slot snapshots with MVCC type when built
Date
Msg-id E1gwIgG-0004ap-9Q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Mark correctly initial slot snapshots with MVCC type when built

When building an initial slot snapshot, snapshots are marked with
historic MVCC snapshots as type with the marker field being set in
SnapBuildBuildSnapshot() but not overriden in SnapBuildInitialSnapshot().
Existing callers of SnapBuildBuildSnapshot() do not care about the type
of snapshot used, but extensions calling it actually may, as reported.

While on it, mark correctly the snapshot type when importing one.  This
is cosmetic as the field is enforced to 0.

Author: Antonin Houska
Reviewed-by: Álvaro Herrera, Michael Paquier
Discussion: https://postgr.es/m/23215.1527665193@localhost
Backpatch-through: 9.4

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/56fadbedbd2f697400b89e7b767cfa4ec67932d6

Modified Files
--------------
src/backend/replication/logical/snapbuild.c | 2 ++
src/backend/utils/time/snapmgr.c            | 2 ++
2 files changed, 4 insertions(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Use varargs macro for CACHEDEBUG
Next
From: Dean Rasheed
Date:
Subject: pgsql: Fix DEFAULT-handling in multi-row VALUES lists for updatablevie