pgsql: Create action triggers when partitions are detached - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Create action triggers when partitions are detached
Date
Msg-id E1gliiK-0004GP-Ae@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Create action triggers when partitions are detached

Detaching a partition from a partitioned table that's constrained by
foreign keys requires additional action triggers on the referenced side;
otherwise, DELETE/UPDATE actions there fail to notice rows in the table
that was partition, and so are incorrectly allowed through.  With this
commit, those triggers are now created.  Conversely, when a table that
has a foreign key is attached as a partition to a table that also has
the same foreign key, those action triggers are no longer needed, so we
remove them.

Add a minimal test case verifying (part of) this.

Authors: Amit Langote, Álvaro Herrera
Discussion: https://postgr.es/m/f2b8ead5-4131-d5a8-8016-2ea0a31250af@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0464fdf07f69452dd67dd798c026d82c956bda33

Modified Files
--------------
src/backend/commands/tablecmds.c          | 71 ++++++++++++++++++++++++++++++-
src/test/regress/expected/foreign_key.out | 28 +++++++++++-
src/test/regress/sql/foreign_key.sql      | 19 ++++++++-
3 files changed, 113 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Flush relcache entries when their FKs are meddled with
Next
From: Tom Lane
Date:
Subject: pgsql: Remove useless bms_copy step in RelationGetIndexAttrBitmap.