pgsql: Don't include genam.h from execnodes.h and relscan.h anymore. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Don't include genam.h from execnodes.h and relscan.h anymore.
Date
Msg-id E1gjDKt-00029P-Ap@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't include genam.h from execnodes.h and relscan.h anymore.

This is the genam.h equivalent of 4c850ecec649c (which removed
heapam.h from a lot of other headers).  There's still a few header
includes of genam.h, but not from central headers anymore.

As a few headers are not indirectly included anymore, execnodes.h and
relscan.h need a few additional includes. Some of the depended on
types were replacable by using the underlying structs, but e.g. for
Snapshot in execnodes.h that'd have gotten more invasive than
reasonable in this commit.

Like the aforementioned commit 4c850ecec649c, this requires adding new
genam.h includes to a number of backend files, which likely is also
required in a few external projects.

Author: Andres Freund
Discussion: https://postgr.es/m/20190114000701.y4ttcb74jpskkcfb@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0944ec54de389b4b8a471ca1f40f1b9d81de1f30

Modified Files
--------------
src/backend/access/heap/heapam.c           |  1 +
src/backend/access/index/genam.c           |  1 +
src/backend/bootstrap/bootstrap.c          |  1 +
src/backend/catalog/dependency.c           |  1 +
src/backend/catalog/heap.c                 |  1 +
src/backend/catalog/indexing.c             |  1 +
src/backend/catalog/objectaddress.c        |  1 +
src/backend/commands/analyze.c             |  1 +
src/backend/commands/constraint.c          |  1 +
src/backend/commands/extension.c           |  1 +
src/backend/commands/matview.c             |  1 +
src/backend/commands/typecmds.c            |  1 +
src/backend/executor/execCurrent.c         |  1 +
src/backend/executor/execIndexing.c        |  1 +
src/backend/executor/execReplication.c     |  1 +
src/backend/executor/nodeBitmapIndexscan.c |  1 +
src/backend/executor/nodeIndexonlyscan.c   |  2 ++
src/backend/optimizer/plan/planner.c       |  1 +
src/backend/utils/init/postinit.c          |  1 +
src/include/access/relscan.h               | 25 +++++++++++++------------
src/include/executor/nodeIndexscan.h       |  1 +
src/include/nodes/execnodes.h              | 22 +++++++++++-----------
22 files changed, 45 insertions(+), 23 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Make naming of tupdesc related structs more consistent withthe
Next
From: Tom Lane
Date:
Subject: pgsql: Finish reverting "recheck_on_update" patch.